[visit-developers] uint in ./databases/paraDIS/RC_cpp_lib/RCDebugStream.C

Mark Miller miller86 at llnl.gov
Thu May 7 18:57:07 EDT 2009


Hi Allen, 

Great. Thanks. Couple things though.

When making a commit, please send email to visit-commits at email.ornl.gov
with subject line like
"SVN Update to Trunk <rev#>" and include list of files that changed.

Also, don't forget to add modification comments to preabmbles to
functions in source files where you make changes.

I know this is a lot of overhead for a 7 character fix. I wind up
agglomerating several of these over a period of a few days before doing
a commit. Sometimes that helps.

Mark

On Thu, 2009-05-07 at 16:00, Allen Sanderson wrote:
> Okay , I have checked this code in unit->unsigned int
> 
> Cheers,
> 
> Allen
> 
> 
> 
> 
> On May 7, 2009, at 4:47 PM, Mark Miller wrote:
> 
> > Hi Allen,
> >
> > This is recently added code (last week) and I am not surprised if it  
> > may
> > not be compiling on all arch we build and release on. Thanks for the
> > fix.
> >
> > I am curios if others Mac users ran into this already thought?
> >
> > Mark
> >
> > On Thu, 2009-05-07 at 15:29, Allen Sanderson wrote:
> >> While compiling:
> >>
> >> ./databases/paraDIS/RC_cpp_lib/RCDebugStream.C
> >> ./databases/paraDIS_tecplot/RC_cpp_lib/RCDebugStream.C
> >>
> >> I got an error on line 425 because of the definition of a uint under
> >> OS X 10.6.4 using
> >>
> >> gcc i686-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5490)
> >>
> >> I change the declaration to unsigned int and all was well.
> >>
> >> I thought it strange to see this but I have not updated my trunk in a
> >> while.
> >>
> >> I plan to check these mods in but wanted to check because I have no
> >> ties to this code.
> >>
> >> Cheers,
> >>
> >> Allen
> >>
> >>
> > -- 
> > Mark C. Miller, Lawrence Livermore National Laboratory
> > email: mailto:miller86 at llnl.gov
> > (M/T/W) (925)-423-5901 (!!LLNL BUSINESS ONLY!!)
> > (Th/F)  (530)-753-8511 (!!LLNL BUSINESS ONLY!!)
> >
-- 
Mark C. Miller, Lawrence Livermore National Laboratory
email: mailto:miller86 at llnl.gov
(M/T/W) (925)-423-5901 (!!LLNL BUSINESS ONLY!!)
(Th/F)  (530)-753-8511 (!!LLNL BUSINESS ONLY!!)



More information about the visit-developers mailing list